Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use WithBatcher while adding a exporter to a provider in examples #1039

Closed
XSAM opened this issue Aug 6, 2020 · 0 comments · Fixed by #1044
Closed

Use WithBatcher while adding a exporter to a provider in examples #1039

XSAM opened this issue Aug 6, 2020 · 0 comments · Fixed by #1044

Comments

@XSAM
Copy link
Member

XSAM commented Aug 6, 2020

Some examples use SpanSyncer to export spans. But SpanSyncer is called synchronously, and users may just copy and paste to their projects, which will add latencies to the thread of users, say, a couple of milliseconds maybe.

So, maybe we should use WithBatcher instead of WithSyncer to add exporter to a provider in examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant