Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sampler interface should return Tracestate #1341

Closed
XSAM opened this issue Nov 16, 2020 · 1 comment · Fixed by #1432
Closed

Sampler interface should return Tracestate #1341

XSAM opened this issue Nov 16, 2020 · 1 comment · Fixed by #1432
Labels
area:trace Part of OpenTelemetry tracing pkg:SDK Related to an SDK package
Projects
P1 Burndown OpenTelemetry Go RC
Milestone
RC1

Comments

@XSAM
Copy link
Member

XSAM commented Nov 16, 2020

According to the specification, Sampler should return SamplingResult that contains Tracestate.
@XSAM XSAM added area:trace Part of OpenTelemetry tracing pkg:SDK Related to an SDK package labels Nov 16, 2020
@Aneurysm9
Copy link
Member

Once #1340 lands we'll have TraceState in the SpanContext provided to the samplers and it should be relatively straightforward to update the SamplingResult struct to include a TraceState.

@MrAlias MrAlias added this to To do in P1 Burndown via automation Nov 19, 2020
@MrAlias MrAlias added this to To do in OpenTelemetry Go RC via automation Nov 19, 2020
@MrAlias MrAlias added this to the RC1 milestone Nov 19, 2020
@ozerovandrei ozerovandrei mentioned this issue Jan 2, 2021
Merged
P1 Burndown automation moved this from To do to Done Jan 6, 2021
OpenTelemetry Go RC automation moved this from To do to Done Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:trace Part of OpenTelemetry tracing pkg:SDK Related to an SDK package
Projects
No open projects
OpenTelemetry Go RC
  
Done
P1 Burndown
  
Done
Milestone
RC1
Development

Successfully merging a pull request may close this issue.

Add Tracestate into the SamplingResult struct ozerovandrei/opentelemetry-go
3 participants
@Aneurysm9 @MrAlias @XSAM