Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate API from SDK in Go repo #20

Closed
jmacd opened this issue Jun 24, 2019 · 3 comments · Fixed by #27
Closed

Separate API from SDK in Go repo #20

jmacd opened this issue Jun 24, 2019 · 3 comments · Fixed by #27

Comments

@jmacd
Copy link
Contributor

jmacd commented Jun 24, 2019

The current prototype that was merged into this repository was unfinished work, in part because it was created while the OpenTelemetry specification was not finished.

The prototype included several concepts at the API level that were dedicated to streaming events to an asynchronous or out-of-process observer as part of the PoC. These types, in particular "ScopeID" are not needed for an in-process span and metrics exporter. To complete this work, the API should have a pure interface that an SDK can provide, for example:

https://github.com/tigrannajaryan/otelapi-compat/
@jmacd
Copy link
Contributor Author

jmacd commented Jun 24, 2019

To fill in a bit more detail, the entire api/scope package will disappear into the streaming implementation, along with the core.ScopeID type. It's not clear to me yet what memory allocations will be added as a result of removing this type, I think some code will be needed to sort this out.

@iredelmeier iredelmeier mentioned this issue Jun 25, 2019
Closed
@rghetia rghetia mentioned this issue Jun 26, 2019
Merged
@jmacd
Copy link
Contributor Author

jmacd commented Jun 27, 2019

@iredelmeier

@jmacd
Copy link
Contributor Author

jmacd commented Jul 1, 2019

The Scope stuff isn't separated yet.

@jmacd jmacd reopened this Jul 1, 2019
@jmacd jmacd mentioned this issue Jul 9, 2019
Merged
@jmacd jmacd closed this as completed Jul 15, 2019
hstan referenced this issue in hstan/opentelemetry-go Oct 15, 2020
@MikeGoldsmith @jmacd @MrAlias
Add Macaron plugin (#20)
e70e751 
* add internal mocking files

* add macaron/v1 plugin

* update docker port mapping

* tidy up mod files

* use empty string for requst path

* Apply suggestions from code review

Accept the suggestion

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Upgrade to v0.5.0

* Remove unused unexported const

* Rename imports to match style

* Fix tests

Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <codingalias@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

move span, trace and event implementation to sdk. rghetia/opentelemetry-go
1 participant
@jmacd