Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the sdk/metric/aggregator/exact aggregator #2346

Closed
jmacd opened this issue Nov 5, 2021 · 0 comments · Fixed by #2348
Closed

Remove the sdk/metric/aggregator/exact aggregator #2346

jmacd opened this issue Nov 5, 2021 · 0 comments · Fixed by #2348
Labels
enhancement New feature or request

Comments

@jmacd
Copy link
Contributor

jmacd commented Nov 5, 2021

Problem Statement

This aggregator dates from very early in the prototype. It was used to demonstrate a Summary-like metric aggregation, including the raw data used to calculate precise quantiles. However, it is a misleading type and produces confusion, particularly because the OTLP exporter turns the type into raw gauge points, meaning it exposes a route from Histogram instruments to Gauge data.

Twice today I answered questions from confused users who used the simple NewWithExactDistribution() aggregator selector and got a bunch of gauge points.

Proposed Solution

Remove this code.

Alternatives

Users can implement this aggregator easily. One of the "near misses" for this code is to support passing raw data through the OTel API directly to another metrics library. This aggregator doesn't support that use-case very well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant