You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Calling Shutdown on TracerProvider (and probably on Stop in metrics controller.Controller too) causes closing of underlying grpc connection through TracerProvider.Shutdown->SpanProcessor.Shutdown->SpanExporter.Shutdown->Client.Stop.
This is not obvious because user can provide his own grpc client using otlptracegrpc.WithGRPCConn.
Proposed Solution
Documentation and doc comments should explicitly mention that all exporter connections are closed automatically during shutdown
Alternatives
Grpc client is not closed on shutdown when it's provided using otlptracegrpc.WithGRPCConn
Additional Context
This lack of info causes confusion. When user tries to close the connection manually, he gets Rpc error: code = Canceled desc = grpc: the client connection is closing.
The text was updated successfully, but these errors were encountered:
Originally the exporter managed the lifecycle of the connection, so it made sense to close the connection when shutdown. Now that the exporter doesn't, at least not when it's provided a connection, I think we might not want to also close it when shutting down. I know this will make our logic a bit more complex, but just like the consumer shouldn't close the channel, I think that the consumer shouldn't close the connection.
Problem Statement
Calling
Shutdown
onTracerProvider
(and probably onStop
in metricscontroller.Controller
too) causes closing of underlying grpc connection throughTracerProvider.Shutdown->SpanProcessor.Shutdown->SpanExporter.Shutdown->Client.Stop
.This is not obvious because user can provide his own grpc client using
otlptracegrpc.WithGRPCConn
.Proposed Solution
Documentation and doc comments should explicitly mention that all exporter connections are closed automatically during shutdown
Alternatives
Grpc client is not closed on shutdown when it's provided using
otlptracegrpc.WithGRPCConn
Additional Context
This lack of info causes confusion. When user tries to close the connection manually, he gets
Rpc error: code = Canceled desc = grpc: the client connection is closing
.The text was updated successfully, but these errors were encountered: