Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the sum aggregator #2972

Closed
4 tasks done
MrAlias opened this issue Jun 22, 2022 · 3 comments
Closed
4 tasks done

Implement the sum aggregator #2972

MrAlias opened this issue Jun 22, 2022 · 3 comments
Assignees
@MrAlias
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Milestone
Metric SDK: Alpha

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Jun 22, 2022 •
edited

Blocked by #2954

Skeleton structure introduced here

  • Aggregate all recorded measurements as an arithmetic sum
  • Group measurement aggregations based on recorded attributes
  • Full test coverage
  • Benchmarks for CPU and memory performance
@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Jun 22, 2022
@MrAlias MrAlias added this to the Metric SDK: Alpha milestone Jun 22, 2022
@MrAlias MrAlias mentioned this issue Jun 22, 2022
Closed
@MrAlias MrAlias self-assigned this Jul 7, 2022
@MrAlias
Copy link
Contributor Author

MrAlias commented Jul 7, 2022

This includes both delta and cumulative implementation.

@MrAlias MrAlias mentioned this issue Jul 7, 2022
Merged
@MrAlias
Copy link
Contributor Author

MrAlias commented Jul 27, 2022

Based on this conversation, I do not plan to handle input data validation in the aggregator. The validation that sum input is zero or greater is left for the instrument implementation in #2814.

@MrAlias
Copy link
Contributor Author

MrAlias commented Aug 4, 2022

Closed with #3000

@MrAlias MrAlias closed this as completed Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrAlias MrAlias

Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Projects
No open projects
OpenTelemetry Go: Metric SDK (Alpha)
Status: Done
Milestone
Metric SDK: Alpha
Development

No branches or pull requests
1 participant
@MrAlias