Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support instrumentation scope attributes #3129

Closed
4 tasks done
MrAlias opened this issue Aug 30, 2022 · 2 comments · Fixed by #3132
Closed
4 tasks done

Support instrumentation scope attributes #3129

MrAlias opened this issue Aug 30, 2022 · 2 comments · Fixed by #3132
Assignees
@MrAlias
Labels
area:metrics Part of OpenTelemetry Metrics area:trace Part of OpenTelemetry tracing enhancement New feature or request pkg:API Related to an API package pkg:SDK Related to an SDK package
Milestone
Release v1.10.0

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Aug 30, 2022 •
edited

@MrAlias MrAlias added enhancement New feature or request pkg:API Related to an API package pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics area:trace Part of OpenTelemetry tracing labels Aug 30, 2022
@MrAlias MrAlias added this to the Release v1.10.0 milestone Aug 30, 2022
@MrAlias MrAlias self-assigned this Aug 30, 2022
@MrAlias
Copy link
Contributor Author

MrAlias commented Aug 30, 2022

The instrumentation Scope is currently comparable. If we add an attribute field of type []attribute.KeyValue it will no longer be. Given this was released as a stable version already, I do not think we can do that.

@MrAlias
Copy link
Contributor Author

MrAlias commented Aug 30, 2022

The instrumentation Scope is currently comparable. If we add an attribute field of type []attribute.KeyValue it will no longer be. Given this was released as a stable version already, I do not think we can do that.

Because of this the new instrumentation scope field should be an attribute.Set.

This was referenced Aug 30, 2022
Merged
Merged
Merged
@MrAlias MrAlias mentioned this issue Sep 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrAlias MrAlias

Labels
area:metrics Part of OpenTelemetry Metrics area:trace Part of OpenTelemetry tracing enhancement New feature or request pkg:API Related to an API package pkg:SDK Related to an SDK package
Projects
None yet
Milestone
Release v1.10.0
Development

Successfully merging a pull request may close this issue.

Add WithScopeAttributes MeterOption to metric API package MrAlias/opentelemetry-go
2 participants
@MrAlias and others