Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baggage member validation in ParseMember #3467

Closed
FatemehRahmanzadeh opened this issue Nov 14, 2022 · 2 comments
Closed

baggage member validation in ParseMember #3467

FatemehRahmanzadeh opened this issue Nov 14, 2022 · 2 comments
Labels
area:baggage Part of OpenTelemetry baggage question Further information is requested response needed Waiting on user input before progress can be made

Comments

@FatemehRahmanzadeh
Copy link

Hi, I have an issue with extracting baggage header recived from node js service to my golang service.
my header contains not allowed characters like (semicolon, white space,...) but I did percent-encode them before injecting to headers...
my question is: W3C rules are checking in opentelemetry baggage package against member value after urlunscape the value.
But I think it must only check the baggage header value.
Are W3C rules also needed for baggage member inside service?
or just for transferring data between services?
I would appreciate any answer related to solve my problem.

@MrAlias MrAlias added question Further information is requested area:baggage Part of OpenTelemetry baggage labels Nov 29, 2022
@MrAlias
Copy link
Contributor

MrAlias commented Nov 29, 2022

You need to pass valid baggage members according to the W3C specification to Baggage because these are the members that will be transferred between services. The API is intentional.

Do you have an example of code that demonstrates the thing you are trying to achieve? Is there something you are not able to do with the current API?

@MrAlias MrAlias added the response needed Waiting on user input before progress can be made label Nov 29, 2022
@MrAlias
Copy link
Contributor

MrAlias commented Feb 17, 2023

Closing as this looks stale. Please re-open if this was an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:baggage Part of OpenTelemetry baggage question Further information is requested response needed Waiting on user input before progress can be made
Projects
None yet
Development

No branches or pull requests

2 participants