Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add opentelemetry collector/agent exporter for metrics #377

Closed
rghetia opened this issue Dec 9, 2019 · 4 comments · Fixed by #544
Closed

Add opentelemetry collector/agent exporter for metrics #377

rghetia opened this issue Dec 9, 2019 · 4 comments · Fixed by #544
Assignees
@MrAlias
Labels
area:metrics Part of OpenTelemetry Metrics
Milestone
Alpha v0.3 (Beta)

Comments

@rghetia
Copy link
Contributor

rghetia commented Dec 9, 2019

Add exporter to export Metrics to Open-telemetry collector.
This is blocked on release of open-telemetry/protocol.
@rghetia rghetia added this to the Alpha v0.4 milestone Dec 9, 2019
@rghetia rghetia added area:metrics Part of OpenTelemetry Metrics exporters blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made labels Dec 9, 2019
@rghetia rghetia modified the milestones: Alpha v0.4, Alpha v0.3 Feb 13, 2020
@rghetia rghetia removed the blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made label Feb 27, 2020
@MrAlias MrAlias mentioned this issue Mar 4, 2020
Merged
@MrAlias
Copy link
Contributor

MrAlias commented Mar 4, 2020

Planning to couple this work with #497 by unifying the exporter: #497 (comment)

@jmacd
Copy link
Contributor

jmacd commented Mar 4, 2020

(@MrAlias I'm glad to hear you're at work on this!)

@MrAlias
Copy link
Contributor

MrAlias commented Mar 9, 2020 •
edited

I've got a rough draft to post as a PR for this (hopefully tomorrow after some cleanup), but it currently only supports the Sum and MinMaxSumCount aggregations. These are the default aggregation strategies for the simple selector, and compatible with the sketch and exact selectors as well. This seems like a decent start at least.

There is an issue with the transfer of data contained in MinMaxSumCount. The OTLP Summary does not have fields for Min or Max, rather it has a Percentiles field (much like prometheus). The rough draft I have together only sends the Sum and Count (existing fields in the OTLP Summary), but there is an incongruence.

I'm pretty sure there is an OTEP or spec issue to drop the Min/Max parts of the MinMaxSumCount aggregation type, so this would be inline with that. However, it seems like a PR to the proto library is needed to synchronize the proto definition with what the spec supports.

I'm interested in what others think of this approach and how to solve the incongruency.

@MrAlias
Copy link
Contributor

MrAlias commented Mar 10, 2020

Created open-telemetry/opentelemetry-proto#122 to add a new data type that will support MinMaxSumCount transport.

@MrAlias MrAlias mentioned this issue Mar 12, 2020
Merged
3 tasks
hstan referenced this issue in hstan/opentelemetry-go Oct 15, 2020
@stanleynguyen
fix(echo): return nil from middleware to handle error only once (#377)
8244cc7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrAlias MrAlias

Labels
area:metrics Part of OpenTelemetry Metrics
Projects
None yet
Milestone
Alpha v0.3 (Beta)
Development

Successfully merging a pull request may close this issue.

Add metrics support to the OTLP exporter MrAlias/opentelemetry-go
3 participants
@jmacd @MrAlias @rghetia