Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Version func to otlpmetric and otlptrace #3956

Merged
merged 15 commits into from Apr 10, 2023

Conversation

remychantenay
Copy link
Contributor

@remychantenay remychantenay commented Mar 31, 2023

Towards #3946

Currently the SDK resources report the SDK version as the API version. If a project uses a different version of the SDK than the API this information will be incorrect. Add a version function to the SDK and use it.

Note: Part of the issue was fixed in #3949

PS: this is my very first contribution, please be gentle 🙏 😉

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 31, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #3956 (1809985) into main (1bc9b56) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3956     +/-   ##
=======================================
- Coverage   82.0%   82.0%   -0.1%     
=======================================
  Files        171     174      +3     
  Lines      12969   12975      +6     
=======================================
+ Hits       10647   10651      +4     
- Misses      2102    2104      +2     
  Partials     220     220             
Impacted Files Coverage Δ
sdk/resource/host_id.go 73.0% <ø> (ø)
exporters/otlp/otlpmetric/internal/header.go 100.0% <100.0%> (ø)
...xporters/otlp/otlpmetric/internal/oconf/options.go 79.8% <100.0%> (ø)
exporters/otlp/otlpmetric/otlpmetrichttp/client.go 76.6% <100.0%> (ø)
exporters/otlp/otlpmetric/version.go 100.0% <100.0%> (ø)
exporters/otlp/otlptrace/internal/header.go 100.0% <100.0%> (ø)
...ters/otlp/otlptrace/internal/otlpconfig/options.go 81.5% <100.0%> (ø)
exporters/otlp/otlptrace/otlptracehttp/client.go 77.5% <100.0%> (ø)
exporters/otlp/otlptrace/version.go 100.0% <100.0%> (ø)

... and 2 files with indirect coverage changes

exporters/otlp/otlpmetric/version.go Outdated Show resolved Hide resolved
exporters/otlp/otlptrace/version.go Outdated Show resolved Hide resolved
sdk/resource/host_id.go Show resolved Hide resolved
remychantenay and others added 4 commits April 4, 2023 18:22
@MrAlias MrAlias merged commit 1b97d78 into open-telemetry:main Apr 10, 2023
21 checks passed
@MrAlias MrAlias mentioned this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants