Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move global metric back to otel/metric/global for minor release #3986

Merged
merged 6 commits into from Apr 13, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Apr 11, 2023

With the major changes we plan to release (#3973, #3971), it was decided at last week's SIG meeting that we will release them as another minor release and then go back into a stability RC cycle. This reverts the move of having the unstable metric API added to the stable global API.

@MrAlias MrAlias added pkg:API Related to an API package area:metrics Part of OpenTelemetry Metrics labels Apr 11, 2023
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #3986 (dd31d31) into main (5134557) will decrease coverage by 0.1%.
The diff coverage is 61.5%.

❗ Current head dd31d31 differs from pull request most recent head afeec40. Consider uploading reports for the commit afeec40 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3986     +/-   ##
=======================================
- Coverage   82.1%   82.1%   -0.1%     
=======================================
  Files        174     175      +1     
  Lines      12975   12975             
=======================================
- Hits       10655   10653      -2     
- Misses      2100    2102      +2     
  Partials     220     220             
Impacted Files Coverage Δ
internal/global/state.go 100.0% <ø> (ø)
metric/internal/global/instruments.go 60.8% <0.0%> (ø)
metric/internal/global/meter.go 93.8% <0.0%> (ø)
metric/global/metric.go 66.6% <33.3%> (ø)
metric/internal/global/state.go 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

@MrAlias MrAlias added this to the v1.15.0 milestone Apr 11, 2023
@MrAlias MrAlias merged commit 8dba38e into open-telemetry:main Apr 13, 2023
19 checks passed
@MrAlias MrAlias deleted the remove-otel-global-metric branch April 13, 2023 14:39
@MrAlias MrAlias modified the milestones: v1.15.0, Metric v0.38.0 Apr 18, 2023
MrAlias added a commit to MrAlias/opentelemetry-go that referenced this pull request Apr 28, 2023
MrAlias added a commit that referenced this pull request May 2, 2023
…se (#3986)" (#4039)

* Revert "Move global metric back to `otel/metric/global` for minor release (#3986)"

This reverts commit 8dba38e.

* Add changes to changelog

* Fix versions and go mod tidy

* Run go-mod-tidy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:API Related to an API package
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants