Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused imports in host_id_bsd.go cause build failures #4040

Closed
Achooo opened this issue Apr 28, 2023 · 1 comment · Fixed by #4041
Closed

Unused imports in host_id_bsd.go cause build failures #4040

Achooo opened this issue Apr 28, 2023 · 1 comment · Fixed by #4041
Labels
bug Something isn't working

Comments

@Achooo
Copy link
Contributor

Achooo commented Apr 28, 2023

Description

Remove unused imports in https://github.com/open-telemetry/opentelemetry-go/blob/main/sdk/resource/host_id_bsd.go

Environment

See these GitHub actions run

  • OS:
    Ubuntu 22.04.2 LTS
  • Architecture: amd64 / 386
  • Go Version: 1.20
  • opentelemetry-go version: v1.15.0-rc.2

Steps To Reproduce

  1. Use the configuration:
  2. Run: go build for particular architecture (e.g. GOARCH=386 CGO_ENABLED=0 go build -tags "")
  3. See error

Screenshot 2023-04-28 at 3 51 53 PM

Expected behavior

Builds correctly
@Achooo Achooo added the bug Something isn't working label Apr 28, 2023
@Achooo
Copy link
Contributor Author

Achooo commented Apr 28, 2023 •
edited

To avoid this in the future, looks like build tags can be enabled manually in golangci-lint which might avoid this problem? Would specific configuration to only check limited linters (e.g. goimports) be needed?

@Achooo Achooo mentioned this issue Apr 28, 2023
Merged
@MrAlias MrAlias mentioned this issue May 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unused imports in host_id_bsd.go Achooo/opentelemetry-go
1 participant
@Achooo