Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn instead of Info log instrument conflict #4202

Merged
merged 2 commits into from Jun 6, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jun 5, 2023

From the specification:

When a duplicate instrument registration occurs, and it is not corrected with a View, a warning SHOULD be emitted.

This logging line was added prior to the Warn function being added. Update the logging to use Warn instead.

@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Jun 5, 2023
@MrAlias MrAlias added this to the Metric SDK v0.40.0 milestone Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #4202 (8ec9919) into main (135c64f) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4202   +/-   ##
=====================================
  Coverage   83.3%   83.4%           
=====================================
  Files        181     181           
  Lines      13940   13940           
=====================================
+ Hits       11625   11629    +4     
+ Misses      2094    2090    -4     
  Partials     221     221           
Impacted Files Coverage Δ
sdk/metric/pipeline.go 89.6% <100.0%> (ø)

... and 1 file with indirect coverage changes

@MrAlias MrAlias merged commit ce46eb5 into open-telemetry:main Jun 6, 2023
22 checks passed
@MrAlias MrAlias deleted the warn-inst-conflict branch June 6, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants