Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add otlpmetricgrpc.Expoter and otlpmetrichttp.Exporter #4272

Merged
merged 4 commits into from Jul 1, 2023

Conversation

pellared
Copy link
Member

Fixes #4247
Fixes #4248

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #4272 (1f63deb) into main (41cd6a1) will decrease coverage by 0.1%.
The diff coverage is 51.2%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4272     +/-   ##
=======================================
- Coverage   83.5%   83.5%   -0.1%     
=======================================
  Files        181     183      +2     
  Lines      14189   14211     +22     
=======================================
+ Hits       11861   11875     +14     
- Misses      2100    2108      +8     
  Partials     228     228             
Impacted Files Coverage Δ
exporters/otlp/otlpmetric/otlpmetricgrpc/client.go 87.7% <ø> (+2.0%) ⬆️
exporters/otlp/otlpmetric/otlpmetrichttp/client.go 77.5% <ø> (+0.9%) ⬆️
...porters/otlp/otlpmetric/otlpmetricgrpc/exporter.go 47.0% <47.0%> (ø)
...porters/otlp/otlpmetric/otlpmetrichttp/exporter.go 47.0% <47.0%> (ø)
exporters/otlp/otlpmetric/internal/exporter.go 67.2% <71.4%> (ø)

... and 2 files with indirect coverage changes

@pellared pellared added area:metrics Part of OpenTelemetry Metrics pkg:exporter:otlp Related to the OTLP exporter package labels Jun 30, 2023
@MrAlias MrAlias merged commit 7ebfa8a into open-telemetry:main Jul 1, 2023
25 of 26 checks passed
@pellared pellared deleted the 4247 branch July 1, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:exporter:otlp Related to the OTLP exporter package
Projects
No open projects
3 participants