Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow selection of exponential vs. explicit bucket histogram for OTLP metric exporters via environment variable #4422

Closed
evantorrie opened this issue Aug 7, 2023 · 0 comments · Fixed by #4437
Assignees
Labels
area:metrics Part of OpenTelemetry Metrics enhancement New feature or request pkg:exporter:otlp Related to the OTLP exporter package

Comments

@evantorrie
Copy link
Contributor

evantorrie commented Aug 7, 2023

Problem Statement

The Go SDK supports configuration of OTLP exporters' default aggregation temporality (via OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE), but does not appear to implement configuration of the default aggregation via OTEL_EXPORTER_OTLP_METRICS_DEFAULT_HISTOGRAM_AGGREGATION.

Proposed Solution

Implement selection of exponential histogram as the default histogram aggregation for OTLP metric exporters via the environment variable OTEL_EXPORTER_OTLP_METRICS_DEFAULT_HISTOGRAM_AGGREGATION.

Alternatives

When created via code, the New() function can always be called with WithAggregationSelector() to pass an arbitrary function as the aggregation selector, but the specification says that OTLP exporter aggregation for histograms should be able to be configured without needing to write code.

Prior Art

Seems that solution should be very similar to that used for the temporality preference

@evantorrie evantorrie added the enhancement New feature or request label Aug 7, 2023
@pellared pellared added area:metrics Part of OpenTelemetry Metrics pkg:exporter:otlp Related to the OTLP exporter package labels Aug 8, 2023
@MrAlias MrAlias self-assigned this Aug 11, 2023
@MrAlias MrAlias added this to the v1.17.0/v0.40.0 milestone Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics enhancement New feature or request pkg:exporter:otlp Related to the OTLP exporter package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants