Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate exporters/jaeger #4423

Merged
merged 22 commits into from Aug 15, 2023
Merged

Deprecate exporters/jaeger #4423

merged 22 commits into from Aug 15, 2023

Conversation

pellared
Copy link
Member

@pellared pellared commented Aug 8, 2023 •
edited

Towards #4405

@pellared pellared marked this pull request as ready for review August 8, 2023 13:35
MrAlias
MrAlias reviewed Aug 8, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
example/jaeger/go.mod Show resolved Hide resolved
@pellared pellared requested a review from MrAlias August 8, 2023 16:52
@swi-jared

This comment was marked as resolved.

Sign in to view
@MrAlias MrAlias added this to the v1.17.0/v0.40.0 milestone Aug 8, 2023
@MrAlias MrAlias mentioned this pull request Aug 8, 2023
Closed
MrAlias
MrAlias approved these changes Aug 9, 2023
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
example/jaeger/go.mod Outdated Show resolved Hide resolved
example/jaeger/main.go Outdated Show resolved Hide resolved
@pellared @MrAlias
Apply suggestions from code review
2e5730a 
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
pellared and others added 3 commits August 9, 2023 18:15
@pellared @MrAlias
Apply suggestions from code review
8da137d 
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@pellared
Update go.mod
2db1855
@pellared
Update main.go
29a2acd
@arukiidou arukiidou mentioned this pull request Aug 9, 2023
Closed
@codecov
Copy link

codecov bot commented Aug 15, 2023 •
edited

Codecov Report

Merging #4423 (d3eb2c9) into main (14b3a98) will increase coverage by 0.0%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4423   +/-   ##
=====================================
  Coverage   78.9%   78.9%           
=====================================
  Files        254     254           
  Lines      20646   20646           
=====================================
+ Hits       16301   16303    +2     
+ Misses      4000    3998    -2     
  Partials     345     345

see 1 file with indirect coverage changes

@MrAlias MrAlias merged commit d78820e into open-telemetry:main Aug 15, 2023
22 checks passed
@MrAlias MrAlias mentioned this pull request Aug 25, 2023
Merged
@pellared pellared deleted the deprecate-jaeger branch November 17, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadVikingGod MadVikingGod MadVikingGod approved these changes

@MrAlias MrAlias MrAlias approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9 Aneurysm9 is a code owner

@evantorrie evantorrie Awaiting requested review from evantorrie evantorrie is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung hanyuancheung is a code owner

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.17.0/v0.40.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pellared @swi-jared @MadVikingGod @MrAlias