Increase instrument name maximum length from 63 to 255 characters #4434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
pkg:SDK
MrAlias
requested review from
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4434 +/- ##
=====================================
Coverage 78.8% 78.8%
=====================================
Files 253 253
Lines 20644 20644
=====================================
Hits 16281 16281
Misses 4014 4014
Partials 349 349
|
MrAlias
commented
Aug 10, 2023
dashpole
approved these changes
Aug 10, 2023
|
The open-telemetry/opentelemetry-specification#3648 change seems to reference the instrument name max length changing, but here we are changing the max length of the metric name. Is there no constraint on the name of the instrument in the go sdk? |
pellared
approved these changes
Aug 11, 2023
@CharlieTLe , correct. Just "not empty". For reference: open-telemetry/opentelemetry-specification#3579 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements specification change: open-telemetry/opentelemetry-specification#3648