Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow '/' character in instrument names #4501

Merged
merged 3 commits into from Sep 13, 2023

Conversation

aabmass
Copy link
Member

@aabmass aabmass commented Sep 12, 2023

Fixes #4500

@MrAlias
Copy link
Contributor

MrAlias commented Sep 12, 2023

Can you add a changelog entry for this please?

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #4501 (936a8c4) into main (ac4fca2) will decrease coverage by 0.1%.
Report is 1 commits behind head on main.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4501     +/-   ##
=======================================
- Coverage   81.3%   81.3%   -0.1%     
=======================================
  Files        220     220             
  Lines      17670   17670             
=======================================
- Hits       14378   14376      -2     
- Misses      2992    2994      +2     
  Partials     300     300             
Files Changed Coverage
exporters/otlp/otlpmetric/version.go 100.0%
exporters/otlp/otlptrace/version.go 100.0%
sdk/metric/meter.go 100.0%
sdk/metric/version.go 100.0%
sdk/version.go 100.0%
version.go 100.0%

@aabmass
Copy link
Member Author

aabmass commented Sep 12, 2023

Can you add a changelog entry for this please?

Done

CHANGELOG.md Show resolved Hide resolved
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@MrAlias MrAlias merged commit bcbee2a into open-telemetry:main Sep 13, 2023
22 checks passed
@aabmass aabmass deleted the allow-slash-4500 branch September 13, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow use of "/" in Metrics Instrument Names
4 participants