Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenCensus bridge MUST support exemplars #4572

Closed
dashpole opened this issue Sep 29, 2023 · 0 comments · Fixed by #4585
Closed

OpenCensus bridge MUST support exemplars #4572

dashpole opened this issue Sep 29, 2023 · 0 comments · Fixed by #4585
Labels
bug Something isn't working pkg:bridges Related to a bridge package
Milestone
v1.20.0

Comments

@dashpole
Copy link
Contributor

Description

https://github.com/open-telemetry/opentelemetry-specification/blob/v1.25.0/specification/compatibility/opencensus.md#requirements-1

MUST support exemplar span context in language that provide utilities for recording span context in exemplars

We currently have a TODO for this in the OpenCensus bridge:

opentelemetry-go/bridge/opencensus/internal/ocmetric/metric.go

Line 154 in 60666c5

// TODO: handle exemplars

We do include exemplars in the metricdata package, so this would be feasible to implement.
@dashpole dashpole added bug Something isn't working pkg:bridges Related to a bridge package labels Sep 29, 2023
This was referenced Sep 29, 2023
Closed
Merged
@MrAlias MrAlias added this to the v1.20.0 milestone Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working pkg:bridges Related to a bridge package
Projects
No open projects
Go: Metric OpenCensus Bridge (GA)
Status: Done
Milestone
v1.20.0
Development

Successfully merging a pull request may close this issue.

Add exemplar support to OpenCensus bridge dashpole/opentelemetry-go
2 participants
@dashpole @MrAlias