Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otlptracegrpc otlpconfig adds DialOptions to DialOptions if has DialOptions #4665

Closed
rackerWard opened this issue Oct 23, 2023 · 1 comment · Fixed by #4684
Closed

otlptracegrpc otlpconfig adds DialOptions to DialOptions if has DialOptions #4665

rackerWard opened this issue Oct 23, 2023 · 1 comment · Fixed by #4684
Labels
bug Something isn't working pkg:exporter:otlp Related to the OTLP exporter package

Comments

@rackerWard
Copy link

Description

It is not clear what is the intent of the following code https://github.com/open-telemetry/opentelemetry-go/blob/main/exporters/otlp/otlptrace/otlptracegrpc/internal/otlpconfig/options.go#L144

	if len(cfg.DialOptions) != 0 {
		cfg.DialOptions = append(cfg.DialOptions, cfg.DialOptions...)
	}

Environment

  • OS: [e.g. iOS]
  • Architecture: [e.g. x86, i386]
  • Go Version: [e.g. 1.15]
  • opentelemetry-go version: [e.g. v0.14.0, 3c7face]

Steps To Reproduce

  1. Use the configuration '...'
  2. Run '...'
  3. See error

Expected behavior

A clear and concise description of what you expected to happen.

@rackerWard rackerWard added the bug Something isn't working label Oct 23, 2023
@pellared pellared added the pkg:exporter:otlp Related to the OTLP exporter package label Oct 23, 2023
@pellared
Copy link
Member

Thank you for reporting. I created #4684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pkg:exporter:otlp Related to the OTLP exporter package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants