Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go semver seems not be consistant with otel semver spec #4922

Closed
aygalinc opened this issue Feb 15, 2024 · 7 comments
Closed

Go semver seems not be consistant with otel semver spec #4922

aygalinc opened this issue Feb 15, 2024 · 7 comments
Labels
response needed Waiting on user input before progress can be made

Comments

@aygalinc
Copy link

Hi!

It seems that go semver is not consistent with the otel semver spécification.
As example, semver in version 1.21.0 does not contain the breaking change on http label due to the alignement with ECS spec.
It is a problem because exporter in otel contrib lib rely on this so actually on our system the exporter IS not able to do the mapping btw appinsight field and otel label.

@aygalinc
Copy link
Author

@MrAlias
Copy link
Contributor

MrAlias commented Feb 15, 2024

Can you please provide specifics of your issue? What semantic conventions are you missing?

We generated v1.21.0 using the v1.21.0 version of semantic conventions. There shouldn't be anything missing.

@MrAlias MrAlias added the response needed Waiting on user input before progress can be made label Feb 15, 2024
@aygalinc
Copy link
Author

By semantic conv i refer to : https://opentelemetry.io/docs/specs/semconv/http/http-spans/ .
It seems thatsome part of the info can be fined inl : https://github.com/open-telemetry/semantic-conventions/blob/main/model/http-common.yaml (the http.response.status_code for example) and specific tracing part in https://github.com/open-telemetry/semantic-conventions/blob/main/model/trace/http.yaml .

If i look the several code generation at some point the directory http and net start to deasepear in the opentelemtry-go repo.
Maybe reference model used by your generator have been moved.

I am not a go developer but happy to help if i can do something to restore this.

@MrAlias
Copy link
Contributor

MrAlias commented Feb 15, 2024

The evolution of semantic conventions is managed here: https://github.com/open-telemetry/semantic-conventions

They have made breaking changes in many of their subsequent releases. We package release version within their own Go package. Please refer to the appropriate semconv package that contains the things you need.

@MrAlias
Copy link
Contributor

MrAlias commented Feb 15, 2024

I'm going to close this as it seems like the issue here is a misunderstanding about the upstream semantic convention stability policy and how that is implemented in the Go project.

If you find an issue where one of our semconv packages does not contain a semconv value from the upstream repository please open a new issue targeted at that value.

@MrAlias MrAlias closed this as not planned Won't fix, can't repro, duplicate, stale Feb 15, 2024
@MrAlias
Copy link
Contributor

MrAlias commented Feb 15, 2024

@aygalinc heads up, the semconv package linked from open-telemetry/opentelemetry-collector-contrib#31255 is not the same as https://pkg.go.dev/go.opentelemetry.io/otel/semconv

@aygalinc
Copy link
Author

Oh sorry i Mixed the packagé when i navigate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
response needed Waiting on user input before progress can be made
Projects
None yet
Development

No branches or pull requests

2 participants