Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SeverityUndefined to otel/log #5072

Merged
merged 3 commits into from Mar 14, 2024
Merged

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Mar 13, 2024

Resolve #5067

@MrAlias MrAlias marked this pull request as ready for review March 13, 2024 20:10
@MrAlias MrAlias added the area:logs Part of OpenTelemetry logs label Mar 13, 2024
@MrAlias MrAlias added this to the v1.25.0 milestone Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 83.2%. Comparing base (ca35244) to head (385cdb7).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #5072     +/-   ##
=======================================
- Coverage   83.2%   83.2%   -0.1%     
=======================================
  Files        243     243             
  Lines      15909   15908      -1     
=======================================
- Hits       13246   13245      -1     
  Misses      2375    2375             
  Partials     288     288             
Files Coverage Δ
log/severity_string.go 50.0% <0.0%> (-10.0%) ⬇️

@MrAlias MrAlias merged commit 42c1708 into open-telemetry:main Mar 14, 2024
24 of 25 checks passed
@MrAlias MrAlias deleted the undefined-sev branch March 14, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:logs Part of OpenTelemetry logs
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

log: Add SeverityUndefined
4 participants