Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move KeyValue from core package into key and rename key to kv #704

Closed
tensorchen opened this issue May 7, 2020 · 2 comments · Fixed by #720
Closed

Move KeyValue from core package into key and rename key to kv #704

tensorchen opened this issue May 7, 2020 · 2 comments · Fixed by #720
Labels
pkg:API Related to an API package

Comments

@tensorchen
Copy link
Member

No description provided.

@tensorchen tensorchen changed the title Move KeyValue core package into key and rename key to kv Move KeyValue from core package into key and rename key to kv May 7, 2020
@MrAlias
Copy link
Contributor

MrAlias commented May 7, 2020

@tensorchen can you provide some context around what you are trying to achieve and what is motivating this?

@MrAlias MrAlias added the pkg:API Related to an API package label May 7, 2020
@tensorchen
Copy link
Member Author

Consider splitting package api/core in more meaningful packages. Package names are very important to readability, and core isn't great.

Finally, the core package is expected to be eliminated. Part of the job is move KeyValue from core package into key and rename key to kv

This relates to #261

This was referenced May 11, 2020
Closed
Merged
@MrAlias MrAlias linked a pull request May 13, 2020 that will close this issue
Move core and key to kv package #720
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pkg:API Related to an API package
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move core and key to kv package tensorchen/opentelemetry-go
2 participants
@MrAlias @tensorchen