Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossibility to set up ephemeral-storage value in the opentelemetry-collector values.yaml #1104

Closed
skyzy06 opened this issue Mar 28, 2024 · 5 comments
Assignees
Labels
chart:collector Issue related to opentelemetry-collector helm chart enhancement New feature or request

Comments

@skyzy06
Copy link
Contributor

skyzy06 commented Mar 28, 2024

Due to some constraints on our platforms, we need to define explicitly the ephemeral-storage request and limit for our deployment.
This is a stable feature of k8s since v1.25: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#local-ephemeral-storage
However helm lint is raising an error when we tried to add the property:

14:28:28  [ERROR] templates/: values don't meet the specifications of the schema(s) in the following chart(s):
14:28:28  opentelemetry-collector:
14:28:28  - resources.limits: Additional property ephemeral-storage is not allowed
14:28:28  - resources.requests: Additional property ephemeral-storage is not allowed

It's due to the fact that values.schema.json is blocking any additional property.

The solution to this issue is to add the support of this property in the chart under the limits and requests properties:

"ephemeral-storage": {
  "type": "string"
}

I have already a pull request about this change if you need a better idea of the change: Add support of ephemeral-storage in the resources. My issue is only with the collector but I propagated the change to the operator and eBPF as well.

@TylerHelmuth
Copy link
Member

@skyzy06 this makes sense. Please open a PR for the opentelemetry-collector. If the feature is needed in other charts we can add that later.

@skyzy06
Copy link
Contributor Author

skyzy06 commented Mar 29, 2024

Hello @TylerHelmuth, thank you for your feedback, I updated my PR to edit only the opentelemetry-collector.

@TylerHelmuth TylerHelmuth added enhancement New feature or request chart:collector Issue related to opentelemetry-collector helm chart labels Apr 2, 2024
@ifalex
Copy link

ifalex commented Apr 3, 2024

Hello,
We encountered this also in opentelemetry-operator.manager. Was working on older versions of the chart 0.44.2 for example.

@ifalex
Copy link

ifalex commented Apr 3, 2024

@TylerHelmuth how would you like to proceed in this situation? Would you like me to create a new PR for the other one needing it? Or we update the current one to support also the others as initially done by @skyzy06 . Helm lint will fail for all the components in place unfortunately.

@skyzy06 skyzy06 changed the title Impossibility to set up ephemeral-storage value in the opentemetry-collector values.yaml Impossibility to set up ephemeral-storage value in the opentelemetry-collector values.yaml Apr 3, 2024
@TylerHelmuth
Copy link
Member

We like changes to a chart in their own PR. Please open a new PR for the operator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart:collector Issue related to opentelemetry-collector helm chart enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants