Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of ephemeral-storage resource definition for opentelemetry-collector #1103

Merged

Conversation

skyzy06
Copy link
Contributor

@skyzy06 skyzy06 commented Mar 28, 2024

Following the discussion on this issue : Impossibility to set up ephemeral-storage value in the opentemetry-collector values.yaml
As additional values are not allowed, adding explicitly the support of ephemeral-storage value in the resources.

Copy link

linux-foundation-easycla bot commented Mar 28, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: skyzy06 / name: Thomas Clop (9f6707a)

@TylerHelmuth
Copy link
Member

@skyzy06 please open an issue for use to discuss this new feature and the problem it solves.

@skyzy06 skyzy06 force-pushed the feature/ephemeral-storage branch 3 times, most recently from f31d13a to 09198ae Compare March 29, 2024 08:40
@skyzy06 skyzy06 changed the title Add support of ephemeral-storage in the resources Add support of ephemeral-storage resource definition for opentelemetry-collector Mar 29, 2024
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run make generate-examples CHARTS=opentelemetry-collector

charts/opentelemetry-collector/values.yaml Outdated Show resolved Hide resolved
@TylerHelmuth TylerHelmuth merged commit 48b9764 into open-telemetry:main Apr 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants