Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[collector] Separate command and args #1149

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

TylerHelmuth
Copy link
Member

This PR separates the command section into both command and args. When a command.name is provided it will get set, overriding the ENTRYPOINT in the container.

args works with command when it is provided, otherwise they are passed to the entrypoint.

Since our default command name is the same as the default image's ENTRYPOINT, removing it is a non-breaking change.

Related to #1148

@jaronoff97
Copy link
Contributor

jaronoff97 commented Apr 18, 2024

@TylerHelmuth is any e2e testing run this for chart? i.e. are we positive data is flowing through the collector if the tests are passing? I didn't see any indication of that from the test logs

@TylerHelmuth
Copy link
Member Author

TylerHelmuth commented Apr 18, 2024

@jaronoff97 no the ci folder only tests that the chart is installable (the pod starts up). I did test locally (and I shouldve put that in the description)

image

image

@TylerHelmuth TylerHelmuth merged commit 6ca3468 into open-telemetry:main Apr 19, 2024
3 checks passed
@TylerHelmuth TylerHelmuth deleted the use-args branch April 19, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants