Add Presets for opentelemetry-kube-stack #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaronoff97
commented
May 3, 2024
charts/opentelemetry-kube-stack/examples/cloud-demo/values.yaml
Outdated
Show resolved
Hide resolved
charts/opentelemetry-kube-stack/examples/cloud-demo/values.yaml
Outdated
Show resolved
Hide resolved
| instrumentation: | ||
| enabled: true | ||
| env: | ||
| - name: OTEL_K8S_NODE_NAME |
There was a problem hiding this comment.
I'm not 100% sure doing this works for the SDKs... I haven't tested this but i think it would work!
|
blocked by #1175 |
jvoravong
reviewed
May 10, 2024
charts/opentelemetry-kube-stack/examples/cloud-demo/rendered/bridge.yaml
Outdated
Show resolved
Hide resolved
jvoravong
reviewed
May 13, 2024
|
Most of these changes lgtm. Left a couple small comments. |
|
@jaronoff97 FYI I'm not planning to look at this until you remove the |
|
@TylerHelmuth yep, and im not going to remove that until #1176 is done :D |
povilasv
reviewed
May 17, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
I need to rebase off main and use the new CRDs :D i'm on vacation right now, but I want to get to this soon. |
…harts into add-presets
jaronoff97
changed the title
povilasv
reviewed
Jun 27, 2024
TylerHelmuth
reviewed
Jul 1, 2024
TylerHelmuth
approved these changes
Jul 1, 2024
TylerHelmuth
reviewed
Jul 1, 2024
TylerHelmuth
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1081
This PR adds in full presets and default collectors for the chart.
TODO:
generate examplesadd some better validations