[opentelemetry-collector] add service.loadbalancerIP #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stelminator
force-pushed
the
loadbalancerIP
branch
from
b55fe02
to
76aa2aa
Compare
Stelminator
requested review from
a team,
dmitryax and
TylerHelmuth
as code owners
Stelminator
force-pushed
the
loadbalancerIP
branch
from
76aa2aa
to
fc75f7f
Compare
puckpuck
added
the
chart:collector
Stelminator
force-pushed
the
loadbalancerIP
branch
2 times, most recently
from
ce1f8b7
to
f5db55b
Compare
Stelminator
changed the title
|
Can you add a commented entry for this in values.yaml with how to use it? |
Stelminator
force-pushed
the
loadbalancerIP
branch
from
f5db55b
to
1fb45ab
Compare
puckpuck
approved these changes
Dec 14, 2022
TylerHelmuth
approved these changes
Dec 14, 2022
JaredTan95
pushed a commit
to JaredTan95/opentelemetry-helm-charts
that referenced
this pull request
Jan 19, 2023
moh-osman3
pushed a commit
to moh-osman3/opentelemetry-helm-charts
that referenced
this pull request
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know it's deprecated because it doesn't support dualstack, but, that doesn't mean it doesn't still work, and afaik, there isn't yet an alternative.
kubernetes/kubernetes#107235
I'm targeting GKE, and have confirmed that this works as expected in that environment for IPV4 reserved external regional addresses.