Skip to content

Commit

Permalink
Rename runtime attach method (#1077)
Browse files Browse the repository at this point in the history
  • Loading branch information
jeanbisutti committed Oct 18, 2023
1 parent e466431 commit 5c6ac6f
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion runtime-attach/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ We give below an example for Spring Boot applications:
public class SpringBootApp {

public static void main(String[] args) {
RuntimeAttach.attachJavaagentToCurrentJVM();
RuntimeAttach.attachJavaagentToCurrentJvm();
SpringApplication.run(SpringBootApp.class, args);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public CoreRuntimeAttach(String agentJarResourceName) {
* beginning of the main method.
*/
@SuppressWarnings("MemberName")
public void attachJavaagentToCurrentJVM() {
public void attachJavaagentToCurrentJvm() {
if (!shouldAttach()) {
return;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ public final class RuntimeAttach {
* beginning of the main method.
*/
@SuppressWarnings("MemberName")
public static void attachJavaagentToCurrentJVM() {
public static void attachJavaagentToCurrentJvm() {

CoreRuntimeAttach distroRuntimeAttach = new CoreRuntimeAttach("/otel-agent.jar");

distroRuntimeAttach.attachJavaagentToCurrentJVM();
distroRuntimeAttach.attachJavaagentToCurrentJvm();
}

private RuntimeAttach() {}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public class AgentDisabledByEnvironmentVariableTest extends AbstractAttachmentTe

@Test
void shouldNotAttachWhenAgentDisabledWithEnvVariable() {
RuntimeAttach.attachJavaagentToCurrentJVM();
RuntimeAttach.attachJavaagentToCurrentJvm();
verifyNoAttachment();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public class AgentDisabledBySystemPropertyTest extends AbstractAttachmentTest {

@Test
void shouldNotAttachWhenAgentDisabledWithProperty() {
RuntimeAttach.attachJavaagentToCurrentJVM();
RuntimeAttach.attachJavaagentToCurrentJvm();
verifyNoAttachment();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public class RunTimeAttachBasicTest extends AbstractAttachmentTest {

@Test
void shouldAttach() {
RuntimeAttach.attachJavaagentToCurrentJVM();
RuntimeAttach.attachJavaagentToCurrentJvm();
verifyAttachment();
}

Expand Down

0 comments on commit 5c6ac6f

Please sign in to comment.