stacktrace span processor #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jkwatson
reviewed
Apr 5, 2024
JonasKunz
approved these changes
Apr 9, 2024
span-stacktrace/src/main/java/io/opentelemetry/contrib/stacktrace/StackTraceSpanProcessor.java
Outdated
Show resolved
Hide resolved
…ontrib into span-stacktrace
|
@jackshirazi @JonasKunz when you have a chance, can you review and approve? thanks |
JonasKunz
approved these changes
Apr 12, 2024
jackshirazi
approved these changes
Apr 12, 2024
trask
reviewed
Apr 12, 2024
.../main/java/io/opentelemetry/contrib/stacktrace/util/AbstractSimpleChainingSpanProcessor.java
Outdated
Show resolved
Hide resolved
…ontrib into span-stacktrace
|
@open-telemetry/java-instrumentation-approvers I think it's ready to be reviewed (and maybe merged) now, let me know if there is anything left to fix. |
JonasKunz
approved these changes
Apr 15, 2024
trask
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We'd like to contribute a span processor that allows to capture
code.stacktracewhen the span ends. The main technical challenge is that the SDK does not allow to simply modify spans on end.This is described in detail in the following github discussion open-telemetry/opentelemetry-java-instrumentation#10973
This was originally contributed in our own distribution in https://github.com/elastic/elastic-otel-java with only minor changes to make it fit.
Existing Issue(s):
GH discussion: open-telemetry/opentelemetry-java-instrumentation#10973
Testing:
Unit tests have been provided
Documentation:
Simple description and usage is provided in the module README.md.
Outstanding items:
< Anything that these changes are intentionally missing
that will be needed or can be helpful in the future. >