Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gRPC server example: is Contexts.interceptCall necessary? #83

Closed
zellyn opened this issue Dec 20, 2022 · 0 comments · Fixed by #126
Closed

gRPC server example: is Contexts.interceptCall necessary? #83

zellyn opened this issue Dec 20, 2022 · 0 comments · Fixed by #126

Comments

@zellyn
Copy link

zellyn commented Dec 20, 2022 •
edited
Loading

The gRPC server uses Context.interceptCall instead of directly calling next.startCall. (here).

Is this necessary, or spurious? Contexts.interceptCall will carefully attach and detach the gRPC context when each of its interface methods is called, but does nothing for the OTel context.

Help appreciated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete grpc example trask/opentelemetry-java-examples
1 participant
@zellyn