Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete grpc example #126

Merged
merged 1 commit into from
May 18, 2023
Merged

Delete grpc example #126

merged 1 commit into from
May 18, 2023

Conversation

trask
Copy link
Member

@trask trask commented May 18, 2023

I worry that people are using this as an example of what they should do, instead of using the grpc library instrumentation

Closes #14
Closes #48
Closes #83

@trask trask requested review from a team as code owners May 18, 2023 01:02
Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah good call!

@trask trask merged commit 1c5bbb5 into open-telemetry:main May 18, 2023
6 checks passed
@trask trask deleted the delete-grpc branch July 14, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants