New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update javaagent example #177

Merged

trask merged 1 commit into open-telemetry:main from trask:update-javaagent-example

Jul 19, 2023

Member

trask commented Jul 19, 2023

PRO: this avoids using a 3rd party gradle plugin (de.undercouch.download)

CON: it relies on defining a custom gradle configuration which is maybe not as clear


          Update javaagent example

9656cea

trask requested review from a team as code owners

July 19, 2023 02:26

mateuszrzeszutek approved these changes

View reviewed changes

Member

mateuszrzeszutek left a comment

I like it more this way: it's more "the gradle way" than the plugin we used to use

trask merged commit b241132 into open-telemetry:main

7 checks passed

trask deleted the update-javaagent-example branch

July 19, 2023 14:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment