Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove testing-common dependency on guava #2048

Closed
mateuszrzeszutek opened this issue Jan 14, 2021 · 0 comments · Fixed by #2062
Closed

Remove testing-common dependency on guava #2048

mateuszrzeszutek opened this issue Jan 14, 2021 · 0 comments · Fixed by #2062
Labels
enhancement New feature or request

Comments

@mateuszrzeszutek
Copy link
Member

Is your feature request related to a problem? Please describe.
Right now testing-common depends on guava 20 and it's impossible to update the guava version because several instrumentations use/depend on this version (cassandra, grizzly, ratpack, etc).
With #1643 being merged the javaagent code now uses a separate, shaded guava that will not interfere with the older version used by the instrumented lib (and if it does then it's a bug).
After we remove the test dependency on guava javaagent will use its own version, the instrumented library under test will use its own and we'll be free to upgrade the javaagent one to the newest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant