Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writing InstrumentationModule line by line #2662

Closed
mateuszrzeszutek opened this issue Mar 30, 2021 · 0 comments 路 Fixed by #2793
Closed

Writing InstrumentationModule line by line #2662

mateuszrzeszutek opened this issue Mar 30, 2021 · 0 comments 路 Fixed by #2793
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@mateuszrzeszutek
Copy link
Member

Is your feature request related to a problem? Please describe.
InstrumentationModule is getting increasingly complicated (which is mostly my fault 馃槀 ) and we don't really have a good doc/resource on how to implement one correctly. Sure, there's Javadoc but you have to piece everything together by yourself.

I thought that it would be useful for contributors to have a single doc that explains all conventions and gotchas that you have to know when implementing an InstrumentationModule: module names, injecting helpers, library instrumentation, how to avoid VerifyErrors and so on.

@mateuszrzeszutek mateuszrzeszutek added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant