Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writing InstrumentationModule line by line #2793

Merged

Conversation

mateuszrzeszutek
Copy link
Member

Resolves #2662
And resolves #536 -- after this is merged all questions/tasks will have been solved or have issues created for them.

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😻

I felt like some sub-section headings would help, it was not always clear when jumping from one topic to another, so I suggested some heading, but not sure if it's too much, very happy with whatever you decide, this doc is 💯

docs/contributing/writing-instrumentation-module.md Outdated Show resolved Hide resolved
docs/contributing/writing-instrumentation-module.md Outdated Show resolved Hide resolved
docs/contributing/writing-instrumentation-module.md Outdated Show resolved Hide resolved
docs/contributing/writing-instrumentation-module.md Outdated Show resolved Hide resolved
docs/contributing/writing-instrumentation-module.md Outdated Show resolved Hide resolved
Mateusz Rzeszutek and others added 2 commits April 14, 2021 10:29
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@mateuszrzeszutek
Copy link
Member Author

I felt like some sub-section headings would help, it was not always clear when jumping from one topic to another, so I suggested some heading, but not sure if it's too much, very happy with whatever you decide, this doc is 💯

Those headings really make it look better, thanks!

@trask trask merged commit 2d59d25 into open-telemetry:main Apr 14, 2021
@trask
Copy link
Member

trask commented Apr 14, 2021

🥳

@mateuszrzeszutek mateuszrzeszutek deleted the writing-instrumentation-module branch April 15, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Writing InstrumentationModule line by line Document muzzle
2 participants