Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow capturing DB query params #400

Closed
ghost opened this issue May 11, 2020 · 3 comments
Closed

Allow capturing DB query params #400

ghost opened this issue May 11, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented May 11, 2020

This would be a feature request.
It would be good to have a flag that allowed capturing database query parameters along with the queries.
@iNikem
Copy link
Contributor

iNikem commented May 11, 2020

Do you think as part of the query or as a separate span attribute?

@ghost
Copy link
Author

ghost commented May 11, 2020

Similar to what's available for redis:
"get LIVE_SESSION_USER_SUBSCRIPTION_87159"

Currently mongo traces look like:
{ "_id": "?", "status": "?", "locations": "?" }

If these parameters were populated, it would've been much easier and quicker to understand whats going on. Especially useful when the results of this query will be propagated upstream and used by another query.

@trask trask added the enhancement New feature or request label Jun 2, 2020
trask pushed a commit to trask/opentelemetry-java-instrumentation that referenced this issue Mar 30, 2022
@dependabot
Bump k8s.io/kubectl from 0.22.0 to 0.22.1 (open-telemetry#400)
3cfc069 
Bumps [k8s.io/kubectl](https://github.com/kubernetes/kubectl) from 0.22.0 to 0.22.1.
- [Release notes](https://github.com/kubernetes/kubectl/releases)
- [Commits](kubernetes/kubectl@v0.22.0...v0.22.1)

---
updated-dependencies:
- dependency-name: k8s.io/kubectl
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@trask trask mentioned this issue Jun 30, 2022
Closed
@trask
Copy link
Member

trask commented Aug 16, 2022

hi @ghost! does otel.instrumentation.common.db-statement-sanitizer.enabled address your needs? (see https://opentelemetry.io/docs/instrumentation/java/automatic/agent-config/#db-statement-sanitization)

@trask trask closed this as completed Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trask @iNikem