Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run benchmark from CI once a week #595

Closed
trask opened this issue Jun 28, 2020 · 6 comments
Closed

Run benchmark from CI once a week #595

trask opened this issue Jun 28, 2020 · 6 comments
Labels
area:build Issues about build infra, both local and central

Comments

@trask
Copy link
Member

trask commented Jun 28, 2020

Run both coldstart and runtime benchmark from:

https://github.com/trask/agent-benchmarking

These spin up a number of Azure App Service VMs and report average and median in order to get a more stable result than you can get on a single cloud machine.

On each VM, the tests alternate enabling/disabling the agent, capturing the overhead that enabling the agent incurs.

@trask trask self-assigned this Jun 28, 2020
@iNikem
Copy link
Contributor

iNikem commented Jun 28, 2020

Are you sure about running this on every merge? My concern is the cost :) May be run once a week?

@trask
Copy link
Member Author

trask commented Jun 29, 2020

Agree, will plan to start with once a week. Then we can run the benchmark for longer across more machines and get a more stable result.

@iNikem iNikem added area:build Issues about build infra, both local and central and removed area:tests labels Jul 27, 2020
@trask trask changed the title Run benchmark from CI on merge to master Run benchmark from CI once a week Jul 29, 2020
@anuraaga
Copy link
Contributor

anuraaga commented Sep 3, 2020

Should we start by exporting to a collector within GitHub actions itself? Just spam the spring-boot smoke test container? I don't know if the numbers are reliable or not, but it seems like an easier start than provisioning cloud.

@anuraaga
Copy link
Contributor

anuraaga commented Sep 3, 2020

For reference, I've written this benchmark with testcontainers before for Zipkin, it's basically awk + zipkin + backend + prometheus. https://github.com/openzipkin/zipkin/blob/master/benchmarks/src/test/java/zipkin2/server/ServerIntegratedBenchmark.java

@trask
Copy link
Member Author

trask commented May 9, 2021

cc: @breedx-splk ready made issue 😁

@iNikem
Copy link
Contributor

iNikem commented Sep 30, 2021

We now have https://github.com/open-telemetry/opentelemetry-java-instrumentation/actions/workflows/nightly-benchmark-overhead.yml, should we close this issue @trask ?

@trask trask closed this as completed Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:build Issues about build infra, both local and central
Projects
None yet
Development

No branches or pull requests

3 participants