fix MapConverter bean condition #10346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanbisutti
reviewed
Jan 30, 2024
| properties = { | ||
| "otel.exporter.otlp.enabled=false", | ||
| "otel.metric.export.interval=100", | ||
| "otel.exporter.otlp.headers=a=1,b=2", |
There was a problem hiding this comment.
What do you think about moving this test in the OpenTelemetryAutoConfigurationTest class? In this way, all the property configurations related to the OpenTelemetryAutoConfiguration will be tested in the same class.
There was a problem hiding this comment.
I tried to do that - then found out that context runner works differently - bean conditions are only evaluated with a @SpringBootTest
jeanbisutti
approved these changes
Jan 30, 2024
laurit
reviewed
Jan 30, 2024
...va/io/opentelemetry/instrumentation/spring/autoconfigure/OpenTelemetryAutoConfiguration.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Jan 30, 2024
...va/io/opentelemetry/instrumentation/spring/autoconfigure/OpenTelemetryAutoConfiguration.java
Outdated
Show resolved
Hide resolved
|
@zeitlinger looks like there's a test failure |
should be fixed now |
steverao
pushed a commit
to steverao/opentelemetry-java-instrumentation
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10344