Wrap request to avoid modifying attributes of the original request #10389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenfinnigan
approved these changes
Feb 2, 2024
trask
reviewed
Feb 2, 2024
...nt/src/main/java/org/springframework/web/servlet/v3_1/OpenTelemetryHandlerMappingFilter.java
Outdated
Show resolved
Hide resolved
steverao
pushed a commit
to steverao/opentelemetry-java-instrumentation
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10379
Or spring mvc instrumentation tries to update the root span name/set route at the end of the request if it wasn't already set earlier. This usually happens when the request is rejected for some reason and request processing does not reach the part where request handler is determined and where we usually do the name update. If that is the case we try to find the handler that matches current request and use the patter it matches as the route. This process alters request attributes which is not desired. This PR wraps the original request so that its attributes could be preserved.