Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring starter should support otel.propagators #10408

Merged
merged 5 commits into from
Feb 13, 2024

Conversation

zeitlinger
Copy link
Member

@zeitlinger zeitlinger commented Feb 5, 2024

Follow up to #10292

  • respect otel.propagators as specified spec

Split off:

@zeitlinger zeitlinger self-assigned this Feb 5, 2024
@zeitlinger zeitlinger requested a review from a team as a code owner February 5, 2024 13:42
@zeitlinger zeitlinger marked this pull request as draft February 5, 2024 13:42
@zeitlinger zeitlinger force-pushed the spring-starter-otlp-properties branch from 683cb83 to 3aa0f05 Compare February 6, 2024 07:53
@zeitlinger zeitlinger marked this pull request as ready for review February 6, 2024 07:55
@zeitlinger
Copy link
Member Author

zeitlinger commented Feb 6, 2024

@jeanbisutti created a follow up task for docs: #10419

@zeitlinger zeitlinger changed the title Spring starter should support otel.propagators Spring starter should support otel.propagators, add SystemOutLogRecordExporter Feb 6, 2024
@jeanbisutti
Copy link
Member

Would you mind creating a separate PR for SystemOutLogRecordExporter? This would make it easier to follow the changes.

@zeitlinger zeitlinger force-pushed the spring-starter-otlp-properties branch from 681d17d to 3bd4558 Compare February 6, 2024 12:06
@zeitlinger zeitlinger changed the title Spring starter should support otel.propagators, add SystemOutLogRecordExporter Spring starter should support otel.propagators Feb 6, 2024
@zeitlinger
Copy link
Member Author

Would you mind creating a separate PR for SystemOutLogRecordExporter? This would make it easier to follow the changes.

sure - moved to #10420

Copy link
Member

@jeanbisutti jeanbisutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to stop supporting the spring.application.name property to populate the service name? The two concepts seem to have similar semantics.

@zeitlinger
Copy link
Member Author

Do we want to stop supporting the spring.application.name property to populate the service name? The two concepts seem to have similar semantics.

spring.application.name is a spring standard that is widely in use - so I'd like to keep that.

@trask
Copy link
Member

trask commented Feb 9, 2024

it looks like there's some overlapping commits between this and #10454?

@zeitlinger
Copy link
Member Author

it looks like there's some overlapping commits between this and #10454?

Yes, this pr is the base and should be merged first

@trask trask merged commit 76ab937 into open-telemetry:main Feb 13, 2024
47 checks passed
@zeitlinger zeitlinger deleted the spring-starter-otlp-properties branch February 13, 2024 18:48
steverao pushed a commit to steverao/opentelemetry-java-instrumentation that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants