Better local caching via burrunan/gradle-cache-action #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iNikem
requested review from
anuraaga,
jkwatson,
trask and
tylerbenson
as code owners
vlsi
reviewed
Aug 19, 2020
vlsi
reviewed
Aug 19, 2020
vlsi
reviewed
Aug 19, 2020
tylerbenson
approved these changes
Aug 19, 2020
anuraaga
approved these changes
Aug 19, 2020
| @@ -28,20 +28,14 @@ jobs: | |||
| with: | |||
| java-version: 11 | |||
|
|
|||
| - name: Cache gradle dependencies | |||
| - name: Test | |||
| uses: burrunan/gradle-cache-action@v1 | |||
There was a problem hiding this comment.
Looks like gradle-caching-runner or the like will be a good name. Not surprising to see the best caching comes with having full visibility to Gradle.
There was a problem hiding this comment.
Naming is hard :)
Thanks for the suggestion.
I see JUnit team uses the following, and it can't be folded to a single command, so I'm exploring ways to allow multiple (Gradle? Shell?) commands to be executed (to avoid copy-paste the boring uses:...)
run: |
./gradlew --version
./gradlew build| @@ -28,20 +28,14 @@ jobs: | |||
| with: | |||
| java-version: 11 | |||
|
|
|||
| - name: Cache gradle dependencies | |||
| - name: Test | |||
There was a problem hiding this comment.
While we're here how about Test on ${{matrix.java}}?
There was a problem hiding this comment.
We already have in job name. Isn't it enough?
| @@ -63,20 +57,14 @@ jobs: | |||
| with: | |||
| java-version: 11 | |||
|
|
|||
| - name: Cache gradle dependencies | |||
| - name: Test | |||
There was a problem hiding this comment.
Similarly how about Test latest deps?
| @@ -24,17 +24,11 @@ jobs: | |||
| with: | |||
| java-version: 11 | |||
|
|
|||
| - name: Cache gradle dependencies | |||
| - name: Test | |||
|
Thanks @vlsi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.