Add instrumentation for graphql 20 that does not use deprecated methods #10779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Mar 12, 2024
| library("com.graphql-java:graphql-java:12.0") | ||
| implementation(project(":instrumentation:graphql-java:graphql-java-common:library")) | ||
|
|
||
| testImplementation(project(":instrumentation:graphql-java:graphql-java-common:testing")) |
There was a problem hiding this comment.
do we need latestDepTestLibrary, or that is not needed until next graphql release when the deprecated methods are removed?
There was a problem hiding this comment.
I'll add it. Yes, currently it isn't needed because the tests pass with the latest version. I think this is the first time we have tried to fix the instrumentation before it actually breaks.
laurit
added a commit
to laurit/opentelemetry-java-instrumentation
that referenced
this pull request
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10751
Next version of
graphql-javawill remove the deprecated methods that our instrumentation uses. This PR introduces instrumentation for graphql-java 20.0 that replaces the usage of deprecated apsi with new apis. Hopefully this new instrumentation will also work for the next graphql-java version. This PR also fixes the latest dep tests for graphql-java to use the actual latest version.