Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture http.route for pekko-http #10799

Merged
merged 5 commits into from
Mar 12, 2024
Merged

Capture http.route for pekko-http #10799

merged 5 commits into from
Mar 12, 2024

Conversation

samwright
Copy link
Contributor

All credit goes to @laurit for doing this for akka in PR #10039. I'm just copying it for pekko (the open-source fork of akka).

@samwright
Capture http.route for pekko-http
d4992cc 
All credit goes to @laurit for doing this for akka in PR open-telemetry#10039. I'm just copying it for pekko (the open-source fork of akka).
@samwright
spotlessApply
948a4b7
@samwright samwright requested a review from a team as a code owner March 11, 2024 10:04
@trask trask added this to the v2.2.0 milestone Mar 11, 2024
laurit
laurit reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@laurit laurit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In

opentelemetry-java-instrumentation/docs/supported-libraries.md

Line 37 in a3a5725

| [Apache Pekko HTTP](https://pekko.apache.org/) | 1.0+ | N/A | [HTTP Client Spans], [HTTP Client Metrics], [HTTP Server Spans], [HTTP Server Metrics] |

add Provides `http.route` [2] to the last column similarly to what akka has

samwright and others added 2 commits March 12, 2024 15:23
@samwright @laurit
Apply suggestions from code review
0b74e0d 
Co-authored-by: Lauri Tulmin <tulmin@gmail.com>
@samwright
update supported-libraries.md
d286a8a
@laurit laurit merged commit 1225eb8 into open-telemetry:main Mar 12, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurit laurit laurit approved these changes

@theletterf theletterf Awaiting requested review from theletterf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samwright @laurit @trask