Spring boot 2 smoke test using inheritance #11278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test native
laurit
reviewed
May 3, 2024
laurit
approved these changes
May 3, 2024
zeitlinger
force-pushed
the
spring-boot-2-smoke-test-inheritance
branch
from
6fa6f52
to
759b429
Compare
|
@laurit I've now added the second part, non-reactive smoke tests for spring boot 2. It's a big change - maybe you want to re-review? |
trask
reviewed
May 8, 2024
smoke-tests-otel-starter/spring-boot-non-reactive-2/build.gradle.kts
Outdated
Show resolved
Hide resolved
smoke-tests-otel-starter/spring-boot-non-reactive-2/build.gradle.kts
Outdated
Show resolved
Hide resolved
steverao
reviewed
May 8, 2024
...2/src/main/java/io/opentelemetry/spring/smoketest/OtelSpringStarterSmokeTestApplication.java
Outdated
Show resolved
Hide resolved
steverao
approved these changes
May 8, 2024
zeitlinger
force-pushed
the
spring-boot-2-smoke-test-inheritance
branch
from
57d17e0
to
ab1a698
Compare
laurit
reviewed
May 9, 2024
instrumentation/spring/spring-boot-autoconfigure-3/build.gradle.kts
Outdated
Show resolved
Hide resolved
laurit
reviewed
May 9, 2024
...n-reactive-2/src/test/java/io/opentelemetry/spring/smoketest/OtelSpringStarterSmokeTest.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
May 9, 2024
...n-reactive-3/src/test/java/io/opentelemetry/spring/smoketest/OtelSpringStarterSmokeTest.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
May 9, 2024
...mmon/src/main/java/io/opentelemetry/spring/smoketest/AbstractOtelSpringStarterSmokeTest.java
Outdated
Show resolved
Hide resolved
hannahchan
pushed a commit
to hannahchan/opentelemetry-java-instrumentation
that referenced
this pull request
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11277