use daemon thread for scheduling in jmx-metrics BeanFinder #11337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The committers listed above are authorized under a signed CLA. |
lizongwu
force-pushed
the
fix-jmx-beanfinder-daemon
branch
from
a338dad
to
fad1362
Compare
steverao
approved these changes
May 11, 2024
laurit
approved these changes
May 11, 2024
AlchemyDing
approved these changes
May 13, 2024
jeanbisutti
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In jmx-metrics's BeanFinder, a non-daemon scheduling thread was used to refresh state.
This may interfere jvm's shutdown process in some situation. eg. standalone Tomcat's shutdown.sh process will get stuck if agent is attached to it.