feat(cassandra4): more attributes

[FrankSpitulski]

fixes #1298

[trask]

hey @FrankSpitulski!

we had some discussion recently in #602 and open-telemetry/opentelemetry-specification#968, and want to spec even instrumentation-specific attributes

can you submit a PR to the specification repo first? this is probably where I would start: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/database.md#call-level-attributes-for-specific-technologies

[iNikem]

@FrankSpitulski Are you interested in open a PR in spec repo adding those semantic attributes?

[FrankSpitulski]

Sure, they tagged the issue I made release:after-ga though so I didn't think it was going to go in.

[trask]

Sure, they tagged the issue I made release:after-ga though so I didn't think it was going to go in.

hey @FrankSpitulski, i've asked for clarification open-telemetry/opentelemetry-specification#1058 (comment)

[FrankSpitulski]

@trask should be good now

[anuraaga]

Thanks - small nits

[anuraaga]

Thanks!

[FrankSpitulski]

@trask @iNikem pinging for review please

[trask]

Thanks for getting this into the specs!!

[trask]

@FrankSpitulski thanks for your patience with us, and great work again driving this through the specification process!

[iNikem]

@FrankSpitulski can you please rebase this PR? Then it can finally be merged. Sorry for such slow progress :(

[FrankSpitulski]

@iNikem It's more than a rebase after the changes in #2113. I'll rewrite it to fit as soon as I can.

[FrankSpitulski]

@iNikem I have rebased and updated the code to use the new SqlStatementSanitizer. As @mateuszrzeszutek mentioned it can no longer handle CREATE statements. It also no longer splits out the table name from the keyspace when the statement has the form <keyspace>.<table>, which I believe should be considered a bug in the SqlStatementSanitizer.

[anuraaga]

Let's go ahead and get this in - @mateuszrzeszutek do you mind following up with the SQL issues?

[anuraaga]

@FrankSpitulski Thanks a lot for this contribution and bearing with the long review process! 🙏

[mateuszrzeszutek]

it can no longer handle CREATE statements

I'll create an issue for that 👍

It also no longer splits out the table name from the keyspace when the statement has the form <keyspace>.<table>, which I believe should be considered a bug in the SqlStatementSanitizer.

Actually, this is intentional: spec says that db.sql.table is

the name of the primary table that the operation is acting upon, including the schema name (if applicable).

so whatever sanitizer extracts as "table" may contain the schema name.
I assume that in Cassandra's case keyspace is equivalent to schema name. I think that the best course of action would be to just split the table string in Cassandra instrumentation.

[trask]

🎉 thank you @FrankSpitulski