Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capture mongodb database name as mongo-db.name attribute instead of client description #1419

Merged

Conversation

imavroukakis
Copy link
Contributor

Closes #1376

@imavroukakis
Copy link
Contributor Author

It should probably be discussed what is to be done with the client description and a sensible fallback when a dbName doesn't exist.

Client Description: Should it be added to SemanticAttributes?
Empty/Null database name: Client description might not be a sensible fallback, is returning null acceptable?

@imavroukakis imavroukakis changed the title capture db name instead of client description capture mongodb database name as mongo-db.name attribute instead of client description Oct 19, 2020
Copy link
Contributor

@iNikem iNikem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If db.name is not available, then it is totally Ok to return null. What else can we do? I even think we can remove the current fallback to description.

@imavroukakis
Copy link
Contributor Author

If db.name is not available, then it is totally Ok to return null. What else can we do? I even think we can remove the current fallback to description.

Makes sense. Should client description also be captured if available? That would be outside the scope of this PR, but would be good to get an opinion.

@iNikem
Copy link
Contributor

iNikem commented Oct 19, 2020

Should client description also be captured if available?

If some MongoDB user thinks that this information is useful, then yes. After the corresponding PR to the spec :)

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @imavroukakis!

@trask trask merged commit 1913706 into open-telemetry:master Oct 19, 2020
@imavroukakis imavroukakis deleted the mongo-db.name-attribute-is-incorrect branch October 20, 2020 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mongo db.name attribute is incorrect
4 participants