Log normalised full statement in Redis instrumentations #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
trask and
tylerbenson
as code owners
iNikem
reviewed
Oct 22, 2020
...rc/main/java/io/opentelemetry/javaagent/instrumentation/jedis/v3_0/JedisInstrumentation.java
Show resolved
Hide resolved
instrumentation/jedis/jedis-3.0/src/test/groovy/Jedis30ClientTest.groovy
Outdated
Show resolved
Hide resolved
.../src/main/java/io/opentelemetry/javaagent/instrumentation/redisson/RedissonClientTracer.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
force-pushed
the
use-redis-command-normalization-in-all-redis-instrumentations
branch
from
270b7cc
to
cdde6c6
Compare
iNikem
approved these changes
Oct 26, 2020
|
@open-telemetry/java-instrumentation-approvers this PR could use another reviewer, not from Splunk |
trask
approved these changes
Oct 26, 2020
...rc/main/java/io/opentelemetry/javaagent/instrumentation/jedis/v1_4/JedisInstrumentation.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
force-pushed
the
use-redis-command-normalization-in-all-redis-instrumentations
branch
from
d800679
to
a46d2a2
Compare
anuraaga
approved these changes
Oct 27, 2020
mateuszrzeszutek
force-pushed
the
use-redis-command-normalization-in-all-redis-instrumentations
branch
from
a46d2a2
to
27da9ce
Compare
mateuszrzeszutek
deleted the
use-redis-command-normalization-in-all-redis-instrumentations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1406
Implemented for: Lettuce 5.0, Jedis and Redisson.
Lettuce 4.0 was skipped because args are not accessible, they're written straight into the command's byte array.
Rediscala was skipped because it has a separate class for every command, and every class has separate fields for the command's args. It pretty much requires writing a separate normalizer.