Proper scope handling for Resteasy instrumentations. #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iNikem
requested review from
anuraaga,
jkwatson,
mateuszrzeszutek,
trask and
tylerbenson
as code owners
iNikem
force-pushed
the
resteasy-scope
branch
from
cb9af3a
to
f678821
Compare
trask
approved these changes
Oct 22, 2020
| * JAX-RS Client API doesn't define a good point where we can handle connection failures, so we must | ||
| * handle these errors at the implementation level. | ||
| * Unlike other supported JAX-RS Client implementations, Resteasy's one is very simple and passes | ||
| * all requests through single point. Both sync ADN async! This allows for easy instrumentation and |
There was a problem hiding this comment.
Suggested change
| * all requests through single point. Both sync ADN async! This allows for easy instrumentation and | |
| * all requests through single point. Both sync AND async! This allows for easy instrumentation and |
anuraaga
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1422. This PR solves the original problem with Resteasy. If other JAX-RS client implementations have the same problem, remains to be seen.